Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add images to newly created models #129

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robbiet480
Copy link

This adds images of created devices to new asset models. Images are sourced from AppleDB. More info about their image service can be found at https://github.com/littlebyteorg/apple-device-images

@snipe
Copy link
Member

snipe commented Aug 19, 2024

This looks excellent - thank you! Any chance we can get you to update the readme with the new option?

@robbiet480
Copy link
Author

Sure. However this can't be merged yet as Snipe-IT is constantly throwing an error when sending the payload: {"status":"error","messages":{"image":["The image field must be a file of type: png, gif, jpg, jpeg, svg, bmp, svg+xml, webp, avif."]},"payload":null}. I've opened a support ticket so they can pull logs from my hosted instance. The payload being sent looks like {"category_id": "2", "manufacturer_id": "1", "name": "MacBook Pro (13-inch, M1, 2020)", "model_number": "MacBookPro17,1", "image": "data:image/png;base64,iVBORw0K..."}

@snipe snipe marked this pull request as draft August 19, 2024 19:39
@snipe
Copy link
Member

snipe commented Aug 19, 2024

@robbiet480 I'm looking into it - we can also follow up on Discord ;)

@robbiet480
Copy link
Author

README updated

@snipe
Copy link
Member

snipe commented Aug 19, 2024

Closest thing I can find (I have a meeting in 3 min) is related to this: 14698 (leaving it here as a reminder to myself more than anything.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants